On Wed, Mar 13 2024 at 14:58, Biju Das wrote: >> > - raw_spin_lock(&priv->lock); >> > + raw_spin_lock_irqsave(&priv->lock, flags); >> >> irq_set_type() is always called with irq_desc::lock held and interrupts disabled. What's exactly the >> point of this change? > > Oops, in that case this change is not needed. > > HW manual mentions, interrupt should be disabled while setting the value. > > I will drop this change in next version. I fixed it up locally already. I'm going to merge 1-4 because those are fixes (2/3 are preparatory). #5 wants a change log matching reality though. Thanks, tglx