On 08/03/2024 11:18, Lad, Prabhakar wrote: > Hi Krzysztof, > > Thank you for the review. > > On Thu, Mar 7, 2024 at 1:50 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 07/03/2024 12:42, Prabhakar wrote: >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> >>> This commit adds support to validate the 'interrupts' and 'interrupt-names' >> >> Please do not use "This commit/patch/change", but imperative mood. See >> longer explanation here: >> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 >> > Sure, I will update the description. > >>> properties for every supported SoC. This ensures proper handling and >>> configuration of interrupt-related properties across supported platforms. >>> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> --- >>> v1->v2 >>> * Defined the properties in top-level block instead of moving into >>> if/else block for each SoC. >>> * Used Gen specific callback strings instead of each SoC variant >> >> You are sending quite a lot of patchsets touching the same, all in one >> day. This just adds to the confusion. >> > Ok, I'll make it as a single series. > >>> --- >>> .../bindings/serial/renesas,scif.yaml | 90 +++++++++++++------ >>> 1 file changed, 62 insertions(+), 28 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml >>> index af72c3420453..6ba6b6d52208 100644 >>> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml >>> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml >>> @@ -83,36 +83,24 @@ properties: >>> maxItems: 1 >>> >>> interrupts: >>> - oneOf: >>> - - items: >>> - - description: A combined interrupt >>> - - items: >>> - - description: Error interrupt >>> - - description: Receive buffer full interrupt >>> - - description: Transmit buffer empty interrupt >>> - - description: Break interrupt >>> - - items: >>> - - description: Error interrupt >>> - - description: Receive buffer full interrupt >>> - - description: Transmit buffer empty interrupt >>> - - description: Break interrupt >>> - - description: Data Ready interrupt >>> - - description: Transmit End interrupt >>> + minItems: 1 >>> + items: >>> + - description: Error interrupt or single combined interrupt >> >> That's not correct, your first interrupt can be combined. >> > In here we are combining and making a single list hence the > description is updated as "Error interrupt or single combined > interrupt". so that we dont have to list the items in the below > if/else checks. Also when the interrupts are combined we dont specify > interrupt-names hence in the below check we set "interrupt-names: > false" I know what you did and my comment stands. Best regards, Krzysztof
