Hi Biju,
On Mon, Feb 26, 2024 at 8:47 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable PMIC DA9062 and the built-in RTC, GPIO and ONKEY modules on the
> RZ/{G2UL,Five} SMARC EVK development boards.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> * Dropped disabled status from gpio and onkey nodes.
> * Added gpio hog nodes.
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> @@ -5,6 +5,7 @@
> * Copyright (C) 2022 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/gpio/gpio.h>
Yep, we need this...
> #include "rzg2ul-smarc-pinfunction.dtsi"
> #include "rz-smarc-common.dtsi"
>
> @@ -23,6 +24,63 @@ &cpu_dai {
> &i2c0 {
> clock-frequency = <400000>;
>
> + da9062: pmic@58 {
> + compatible = "dlg,da9062";
> + reg = <0x58>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio {
> + compatible = "dlg,da9062-gpio";
> + };
> +
> + onkey {
> + compatible = "dlg,da9062-onkey";
> + };
> +
> + pmic-good-hog {
> + gpio-hog;
> + gpios = <4 0>;
... so this can be replaced by <4 GPIO_ACTIVE_HIGH> ;-)
> + output-high;
> + line-name = "PMIC_PGOOD";
> + };
Same for the other gpios.
Anyway, LGTM
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.10, with s/0/GPIO_ACTIVE_HIGH/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
