Hello Simon, On Wed, 21 Feb 2024, Simon Horman wrote: > > + * driver authors should consider whether their target device is to be used in > > + * conjunction with a MAC device whose driver calls phylink_pcs_pre_init(). MAC > > + * driver authors should document their requirements for the PCS > > + * pre-initialization. > > + * > > + */ > > +int pcs_config(struct phylink_pcs *pcs); Yes it should, thank you for pointing that out. Best Regards, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com