On Mon, Feb 19, 2024 at 2:59 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Saravana, > > On Fri, Feb 2, 2024 at 10:57 AM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > fw_devlink can detect most overlapping/intersecting cycles. However it was > > missing a few corner cases because of an incorrect optimization logic that > > tries to avoid repeating cycle detection for devices that are already > > marked as part of a cycle. > > Nice (I assume it's due to this patch ;-), with v6.8-rc5 I see much fewer > dependency cycle messages. Thanks! It's not due to this patch. It's due to this other series: https://lore.kernel.org/lkml/20240207011803.2637531-1-saravanak@xxxxxxxxxx/ I forget why the cycle warning doesn't show up between fea80000.csi2 and video@e6ef7000, but I had the same improvement on my test device and there was a valid reason why it doesn't show up. So, an unintentional, but non-buggy benefit of that series. -Saravana > > E.g. on Salvator-XS: > > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef7000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef6000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef5000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef4000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef3000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef2000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef1000/ports/port@1/endpoint@0 > -platform fea80000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef0000/ports/port@1/endpoint@0 > -platform feaa0000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef3000/ports/port@1/endpoint@2 > -platform feaa0000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef2000/ports/port@1/endpoint@2 > -platform feaa0000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef1000/ports/port@1/endpoint@2 > -platform feaa0000.csi2: Fixed dependency cycle(s) with > /soc/video@e6ef0000/ports/port@1/endpoint@2 > -platform fead0000.hdmi: Fixed dependency cycle(s) with > /soc/sound@ec500000/ports/port@1/endpoint > -platform feae0000.hdmi: Fixed dependency cycle(s) with > /soc/sound@ec500000/ports/port@2/endpoint > -platform feb00000.display: Fixed dependency cycle(s) with > /soc/hdmi@feae0000/ports/port@0/endpoint > -platform feb00000.display: Fixed dependency cycle(s) with > /soc/hdmi@fead0000/ports/port@0/endpoint > -platform hdmi0-out: Fixed dependency cycle(s) with > /soc/hdmi@fead0000/ports/port@1/endpoint > -platform hdmi1-out: Fixed dependency cycle(s) with > /soc/hdmi@feae0000/ports/port@1/endpoint > -platform vga-encoder: Fixed dependency cycle(s) with /vga/port/endpoint > -platform vga-encoder: Fixed dependency cycle(s) with > /soc/display@feb00000/ports/port@0/endpoint > > -i2c 2-0010: Fixed dependency cycle(s) with > /soc/sound@ec500000/ports/port@0/endpoint > -i2c 2-0010: Fixed dependency cycle(s) with /soc/sound@ec500000 > > -i2c 4-0070: Fixed dependency cycle(s) with > /soc/csi2@fea80000/ports/port@0/endpoint > -i2c 4-0070: Fixed dependency cycle(s) with > /soc/csi2@feaa0000/ports/port@0/endpoint > -i2c 4-0070: Fixed dependency cycle(s) with /hdmi-in/port/endpoint > -i2c 4-0070: Fixed dependency cycle(s) with /cvbs-in/port/endpoint > > FTR, the only remaining ones (on Salvator-XS) are: > > platform soc: Fixed dependency cycle(s) with > /soc/interrupt-controller@f1010000 > platform e6060000.pinctrl: Fixed dependency cycle(s) with > /soc/pinctrl@e6060000/scif_clk > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
