Hi Niklas, On Mon, Jan 22, 2024 at 5:06 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > On the white-hawk development board the Ethernet TSN IP can be connected > to one of two different external PHYs. One PHY is located on the > breakout board, and the other on the Ethernet sub-board. Which PHY is > connected depends on what resistors are mounted on the board. Actually there are three options: 1. Breakout board, 2. Ethernet sub-board, 3. Ether module board. > The default white-hawk configuration connect the TSN with the PHY on the > breakout board. Unfortunately the standard breakout board do not > populate the external PHY. According to the schematics, this seems to depend on board revision: - rev. 0.909: TSN is wired to 3, - rev. 1.00: TSN is wired to 2. > Add an overlay that can be applied to enable Ethernet TSN support for > those boards that do populate the breakout board, or mount the > appropriate resistors to connect TSN with the Ethernet sub-board. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -84,7 +84,9 @@ dtb-$(CONFIG_ARCH_R8A779F0) += r8a779f4-s4sk.dtb > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk.dtb > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtbo > r8a779g0-white-hawk-ard-audio-da7212-dtbs := r8a779g0-white-hawk.dtb r8a779g0-white-hawk-ard-audio-da7212.dtbo Please add dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-tsn.dtbo so that the .dtbo is considered for installation, too. > +r8a779g0-white-hawk-tsn-dtbs := r8a779g0-white-hawk.dtb r8a779g0-white-hawk-tsn.dtbo > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtb > +dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-tsn.dtb The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds