Hi Wolfram,
On Wed, Feb 14, 2024 at 2:10 PM Wolfram Sang <wsa@xxxxxxxxxx> wrote:
> On Wed, Feb 14, 2024 at 02:01:34PM +0100, Geert Uytterhoeven wrote:
> > From: Cong Dang <cong.dang.xn@xxxxxxxxxxx>
> >
> > Add the SDHI module clock, which is used by the SD Card/MMC Interface on
> > the Renesas R-Car V4M (R8A779H0) SoC.
> >
> > Signed-off-by: Cong Dang <cong.dang.xn@xxxxxxxxxxx>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > + DEF_MOD("sdhi0", 706, R8A779H0_CLK_SD0),
>
> I assume this is correct because you got it to work, so:
>
> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> But documentation is unclear, the diagram above the table says sdhi0 is
> 707 while the table says 706. I guess you reported this already?
Thanks, I had missed that inconsistency.
After adding a dummy module clock for 707 to the clock driver, so
unused 707 gets disabled during late boot, eMMC still works.
After exchanging 706 and 707 in both the clock driver and the .dtsi,
ee140000.mmc times out waiting for SD bus idle.
So 706 must be correct.
I will report the documentation issue.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
