Re: [PATCH v3] pmdomain: renesas: Adjust the waiting time to cover the worst case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 13 Feb 2024 at 01:26, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
> From: Dien Pham <dien.pham.ry@xxxxxxxxxxx>
>
> Description in HWM rev0.51E, 9.4 Usage notes, page 455 tells
>
>         "It takes several hundreds of microseconds to shutting off and
>          resuming power domain. Because actual time required for
>          shutting off and resuming depends on the status of on-board
>          power line, shutoff/resume time is not guaranteed by
>          electrical specification"
>
> Let's assume the safe value of waiting is about 1000us.
>
> Signed-off-by: Dien Pham <dien.pham.ry@xxxxxxxxxxx>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> Signed-off-by: Tho Vu <tho.vu.wh@xxxxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
> v2 -> v3
>         - remove Signed-off-by Geert
>         - add    Reviewed-by   Geert
>
>  drivers/pmdomain/renesas/rcar-sysc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/renesas/rcar-sysc.c b/drivers/pmdomain/renesas/rcar-sysc.c
> index eed47696e825..35d9aa0dfab8 100644
> --- a/drivers/pmdomain/renesas/rcar-sysc.c
> +++ b/drivers/pmdomain/renesas/rcar-sysc.c
> @@ -45,10 +45,10 @@
>  #define PWRER_OFFS             0x14    /* Power Shutoff/Resume Error */
>
>
> -#define SYSCSR_TIMEOUT         100
> +#define SYSCSR_TIMEOUT         1000
>  #define SYSCSR_DELAY_US                1
>
> -#define PWRER_RETRIES          100
> +#define PWRER_RETRIES          1000
>  #define PWRER_DELAY_US         1
>
>  #define SYSCISR_TIMEOUT                1000
> --
> 2.25.1
>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux