On Tue, Feb 6, 2024 at 3:12 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > + IRQ chip > > > -----Original Message----- > > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Sent: Tuesday, February 6, 2024 1:53 PM > > To: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Geert Uytterhoeven > > <geert+renesas@xxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx; linux- > > gpio@xxxxxxxxxxxxxxx; Prabhakar Mahadev Lad <prabhakar.mahadev- > > lad.rj@xxxxxxxxxxxxxx>; biju.das.au <biju.das.au@xxxxxxxxx> > > Subject: [PATCH v2 3/3] pinctrl: renesas: rzg2l: Avoid configuring ISEL in > > gpio_irq_{en,dis}able > > > > Currently on irq_disable(), we are disabling gpio interrupt enable(ISEL). > > That means the pin is just gpio input and not gpio input interrupt any > > more. So, move configuring ISEL in rzg2l_gpio_child_to_parent_hwirq()/ > > rzg2l_gpio_irq_domain_free() so that pin will be gpioint always even > > during irq_disable(). > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > v2: > > * New patch. LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds