Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> It is named T1.8V in the schematics. Also add properties dcoumenting it

documenting

> is always on, also during boot.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -32,11 +32,13 @@ hdmi1_con: endpoint {
>                 };
>         };
>
> -       hdmi_1v8: regulator-hdmi-1v8 {
> +       t1v8: regulator-t1v8 {

"t1p8v"?
Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

>                 compatible = "regulator-fixed";
> -               regulator-name = "hdmi-1v8";
> +               regulator-name = "t1v8";
>                 regulator-min-microvolt = <1800000>;
>                 regulator-max-microvolt = <1800000>;
> +               regulator-boot-on;
> +               regulator-always-on;
>         };
>
>         pcie_1v5: regulator-pcie-1v5 {
> @@ -154,11 +156,11 @@ hdmi@3d {
>
>                                 pd-gpios = <&gpio_exp_75 5 GPIO_ACTIVE_LOW>;
>
> -                               avdd-supply = <&hdmi_1v8>;
> -                               dvdd-supply = <&hdmi_1v8>;
> -                               pvdd-supply = <&hdmi_1v8>;
> +                               avdd-supply = <&t1v8>;
> +                               dvdd-supply = <&t1v8>;
> +                               pvdd-supply = <&t1v8>;
>                                 dvdd-3v-supply = <&reg_3p3v>;
> -                               bgvdd-supply = <&hdmi_1v8>;
> +                               bgvdd-supply = <&t1v8>;
>
>                                 adi,input-depth = <8>;
>                                 adi,input-colorspace = "rgb";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds