Hi Niklas, Thanks for your patch! On Fri, Feb 9, 2024 at 10:22 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > To prepare support for multiple register layouts pointers to register > tables where added to struct cpg_mssr_info. These pointers are suppose supposed > to be filled in at probe time and no intended change in behavior was > intended. > > However the new pointers where only filled in by some paths of the were > driver implemented in clk-rcar-gen3.c. The path implemented in > clk-rcar-gen2.c was not updated leaving the pointers uninitialized > leading to a crash when trying to probe the clocks. > > Fix this by filling in the pointers in the Gen2 code path with the > values used before they where moved to struct cpg_mssr_info. were > Fixes: d413214fb748 ("clk: renesas: Add register pointers into struct cpg_mssr_info") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds