Hi Mark, On Tue, Feb 6, 2024 at 11:09 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > On Tue, Feb 06, 2024 at 10:33:22AM +0100, Geert Uytterhoeven wrote: > > If all of this is true, is there any reason to keep REGCACHE_RBTREE > > around? If not, perhaps REGCACHE_RBTREE should be treated as > > REGCACHE_MAPLE in the regmap core code first, followed by a single > > tree-wide patch to replace REGCACHE_RBTREE? > > There is a very small niche for devices where cache syncs are a > particularly important part of the workload where rbtree's choices might > give better performance, especially on systems with low end CPUs. The REGCACHE_* value is specified by the device, not by the CPU? While some of these MFD devices are on-SoC, and thus there is some relation between device and CPU, several others (e.g. PMICs) are external, and thus might be present on systems with a variety of CPU performance. Perhaps the value should depend on some CPU heuristic instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds