On 31/01/2024 18:26, Andrew Lunn wrote: >> Changes are made specific to the GbEth IP, avoiding potential impact on >> the other Renesas R-Car based SoCs which also use the ravb driver. This >> follows the principle of only submitting patches that we can fully test. > > Are you saying that Renesas does not have access to all Renesas RDKs? > > I don't particularly like the way your first patch makes a copy of > shared functions. Is it not likely that R-Car would also benefit from > this? We have the required RDKs. For the R-Car based SoCs, we need to confirm that gPTP still works if we change the poll/receive code paths - this will require an AVB-capable network switch and additional time to test. So our plan was to handle the GbEth code paths first without affecting R-Car, then follow up with another patch set for the R-Car code paths when we've done the required tests. I discussed this with our team, and we're happy to do this in one go for both R-Car and GbEth code paths if that's preferred. I'll send the patches as an RFC (as Sergey has commented it should be an RFC anyway as it depends on an unmerged patch) and we'll do the gPTP test with a couple of R-Car boards. Thanks, Paul
Attachment:
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
