On 1/4/24 12:37 AM, Jakub Kicinski wrote: [...] >> I don't know this hardware, I don't have the manuals for it, so I can't >> provide a good review. Let's exclude the Ethernet Switch related files. >> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > >> Index: net/MAINTAINERS >> =================================================================== >> --- net.orig/MAINTAINERS >> +++ net/MAINTAINERS >> @@ -18358,6 +18358,9 @@ L: linux-renesas-soc@xxxxxxxxxxxxxxx >> F: Documentation/devicetree/bindings/net/renesas,*.yaml >> F: drivers/net/ethernet/renesas/ >> F: include/linux/sh_eth.h >> +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml >> +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* >> +X: drivers/net/ethernet/renesas/rswitch.* > > First off, very nice to see a refinement of MAINTAINERS to narrow > down the scope and make it more precise. Thanks for doing that. It's long overdue. I've got a lot of the rswitch patches in my inbox which I mostly ignored. Unfortunately, I've been loaded with fixing the Svace (static analyzer) reports for about 2 years now... > The solution itself is not very idiomatic, however :( > IIUC you want to support SuperH and the AVB implementation. > It'd be more usual to make the entry cover only the relevant files. Yeah, figured that out fianally... but still not sure what should I do with Kconfig and Makefile... > And for bonus points perhaps add an entry covering the switch files, > mark that entry as Orphan? Will try to loop in Shimoda-san first -- maybe he'd be brave enough to step in... :-) MBR, Sergey
