On 27.12.2023 12:10, claudiu beznea wrote: >>> -static int ravb_config(struct net_device *ndev) >>> +static int ravb_set_opmode(struct net_device *ndev, u32 opmode) >> Since you pass the complete CCC register value below, you should >> rather call the function ravb_set_ccc() and call the parameter opmode >> ccc. > This will be confusing. E.g., if renaming it ravb_set_ccc() one would > expect to set any fields of CCC though this function but this is not true > as ravb_modify() in this function masks only CCC_OPC. The call of: What about ravb_set_opc() or ravb_set_ccc_opc() ?
