On Sun, Dec 03, 2023 at 10:07:19AM +0000, Biju Das wrote: > Hi Rob Herring, > > Thanks for the feedback, > > > Subject: Re: [PATCH v2 04/11] dt-bindings: thermal: Convert da906{1,2} > > thermal to json-schema > > > > > > On Sat, 02 Dec 2023 19:25:28 +0000, Biju Das wrote: > > > Convert the da906{1,2} thermal device tree binding documentation to > > > json-schema. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > .../bindings/thermal/da9062-thermal.txt | 36 ------------ > > > .../bindings/thermal/dlg,da9062-thermal.yaml | 58 > > > +++++++++++++++++++ > > > 2 files changed, 58 insertions(+), 36 deletions(-) delete mode > > > 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.example.dtb: > > /example-0/i2c/pmic@58: failed to match any schema with compatible: > > ['dlg,da9062'] > > Looks validation is not checking compatible defines in the mfd/da9062.txt file. > So will merge this patch with patch #11 to fix this error. No need to merge it. Just note below the '---' the warning is expected. Rob