Hi Biju,
On Fri, Dec 1, 2023 at 12:09 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable PMIC DA9062 and the built-in RTC on the RZ/{G2UL,Five} SMARC
> EVK.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> @@ -23,6 +23,35 @@ &cpu_dai {
> &i2c0 {
> clock-frequency = <400000>;
>
> + da9062: pmic@58 {
> + compatible = "dlg,da9062";
> + reg = <0x58>;
> +
> + da9062_rtc: rtc {
> + compatible = "dlg,da9062-rtc";
> + };
> +
> + da9062_onkey: onkey {
> + compatible = "dlg,da9062-onkey";
> + status = "disabled";
Why is this disabled? This is connected to the power button.
> + };
> +
> + watchdog {
> + compatible = "dlg,da9062-watchdog";
> + status = "disabled";
> + };
> +
> + thermal {
> + compatible = "dlg,da9062-thermal";
> + status = "disabled";
> + };
> +
> + gpio {
> + compatible = "dlg,da9062-gpio";
> + status = "disabled";
> + };
Why are these three disabled?
If they are truly unused, you can just drop the nodes instead.
> + };
> +
> versa3: clock-generator@68 {
> compatible = "renesas,5p35023";
> reg = <0x68>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
