Re: [net-next] net: ethernet: renesas: rcar_gen4_ptp: Depend on PTP_1588_CLOCK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 29, 2023, at 12:11, Niklas Söderlund wrote:
> When breaking out the Gen4 gPTP support to its own module the dependency
> on the PTP_1588_CLOCK framework was left as optional and only stated for
> the driver using the module. This leads to issues when doing
> COMPILE_TEST of RENESAS_GEN4_PTP separately and PTP_1588_CLOCK is built
> as a module and the other as a built-in. Add an explicit depend on
> PTP_1588_CLOCK.
>
> While at it remove the optional support for PTP_1588_CLOCK from
> RENESAS_ETHER_SWITCH as the driver unconditionally calls the Gen4 gPTP
> module and thus also requires the PTP_1588_CLOCK framework.
>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 8c1c66235e03 ("net: ethernet: renesas: rcar_gen4_ptp: Break out 
> to module")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Ideally someone should rework the driver (and the ravb one) to actually
leave out all the ptp related code when PTP is disabled, but this patch
avoids both the link failure and the possible logic issues for the moment.

     Arnd





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux