Re: [PATCH v2 4/6] net: ravb: Start TX queues after HW initialization succeeded

[Kalesh Anakkur Purayil <kalesh-anakkur.purayil@xxxxxxxxxxxx>]

On Tue, Nov 28, 2023 at 1:35 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:

From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

ravb_phy_start() may fail. If that happens, the TX queues will remain
started. Thus, move the netif_tx_start_all_queues() after PHY is
successfully initialized.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
---

Changes in v2:
- none

Changes since [1]:
- collected Rb tag

[1] https://lore.kernel.org/all/20231120084606.4083194-1-claudiu.beznea.uj@xxxxxxxxxxxxxx/

 drivers/net/ethernet/renesas/ravb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me.

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx> 

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 62a986b5de41..2ef46c71f2bb 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1812,13 +1812,13 @@ static int ravb_open(struct net_device *ndev)
        if (info->gptp)
                ravb_ptp_init(ndev, priv->pdev);

-       netif_tx_start_all_queues(ndev);
-
        /* PHY control start */
        error = ravb_phy_start(ndev);
        if (error)
                goto out_ptp_stop;

+       netif_tx_start_all_queues(ndev);
+
        return 0;

 out_ptp_stop:
--
2.39.2

--

Regards,

Kalesh A P

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature