[geert-renesas-drivers:master 40/53] net/ipv4/tcp_ao.c:1536:13: error: implicit declaration of function 'crypto_ahash_alignmask'; did you mean 'crypto_ahash_alg_name'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master
head:   d2db27106b911291048ef82bee72ed5a489a83e0
commit: f1b3be20bcbbf97ba484e1ed11fa6b86e0df99ee [40/53] Merge remote-tracking branch 'crypto/master' into renesas-drivers
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231101/202311011709.KSZRMITa-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311011709.KSZRMITa-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311011709.KSZRMITa-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   net/ipv4/tcp_ao.c: In function 'tcp_ao_key_alloc':
>> net/ipv4/tcp_ao.c:1536:13: error: implicit declaration of function 'crypto_ahash_alignmask'; did you mean 'crypto_ahash_alg_name'? [-Werror=implicit-function-declaration]
    1536 |         if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) {
         |             ^~~~~~~~~~~~~~~~~~~~~~
         |             crypto_ahash_alg_name
   cc1: some warnings being treated as errors


vim +1536 net/ipv4/tcp_ao.c

4954f17ddefc51 Dmitry Safonov 2023-10-23  1505  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1506  static struct tcp_ao_key *tcp_ao_key_alloc(struct sock *sk,
4954f17ddefc51 Dmitry Safonov 2023-10-23  1507  					   struct tcp_ao_add *cmd)
4954f17ddefc51 Dmitry Safonov 2023-10-23  1508  {
4954f17ddefc51 Dmitry Safonov 2023-10-23  1509  	const char *algo = cmd->alg_name;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1510  	unsigned int digest_size;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1511  	struct crypto_ahash *tfm;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1512  	struct tcp_ao_key *key;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1513  	struct tcp_sigpool hp;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1514  	int err, pool_id;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1515  	size_t size;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1516  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1517  	/* Force null-termination of alg_name */
4954f17ddefc51 Dmitry Safonov 2023-10-23  1518  	cmd->alg_name[ARRAY_SIZE(cmd->alg_name) - 1] = '\0';
4954f17ddefc51 Dmitry Safonov 2023-10-23  1519  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1520  	/* RFC5926, 3.1.1.2. KDF_AES_128_CMAC */
4954f17ddefc51 Dmitry Safonov 2023-10-23  1521  	if (!strcmp("cmac(aes128)", algo))
4954f17ddefc51 Dmitry Safonov 2023-10-23  1522  		algo = "cmac(aes)";
4954f17ddefc51 Dmitry Safonov 2023-10-23  1523  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1524  	/* Full TCP header (th->doff << 2) should fit into scratch area,
4954f17ddefc51 Dmitry Safonov 2023-10-23  1525  	 * see tcp_ao_hash_header().
4954f17ddefc51 Dmitry Safonov 2023-10-23  1526  	 */
4954f17ddefc51 Dmitry Safonov 2023-10-23  1527  	pool_id = tcp_sigpool_alloc_ahash(algo, 60);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1528  	if (pool_id < 0)
4954f17ddefc51 Dmitry Safonov 2023-10-23  1529  		return ERR_PTR(pool_id);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1530  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1531  	err = tcp_sigpool_start(pool_id, &hp);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1532  	if (err)
4954f17ddefc51 Dmitry Safonov 2023-10-23  1533  		goto err_free_pool;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1534  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1535  	tfm = crypto_ahash_reqtfm(hp.req);
4954f17ddefc51 Dmitry Safonov 2023-10-23 @1536  	if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) {
4954f17ddefc51 Dmitry Safonov 2023-10-23  1537  		err = -EOPNOTSUPP;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1538  		goto err_pool_end;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1539  	}
4954f17ddefc51 Dmitry Safonov 2023-10-23  1540  	digest_size = crypto_ahash_digestsize(tfm);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1541  	tcp_sigpool_end(&hp);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1542  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1543  	size = sizeof(struct tcp_ao_key) + (digest_size << 1);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1544  	key = sock_kmalloc(sk, size, GFP_KERNEL);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1545  	if (!key) {
4954f17ddefc51 Dmitry Safonov 2023-10-23  1546  		err = -ENOMEM;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1547  		goto err_free_pool;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1548  	}
4954f17ddefc51 Dmitry Safonov 2023-10-23  1549  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1550  	key->tcp_sigpool_id = pool_id;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1551  	key->digest_size = digest_size;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1552  	return key;
4954f17ddefc51 Dmitry Safonov 2023-10-23  1553  
4954f17ddefc51 Dmitry Safonov 2023-10-23  1554  err_pool_end:
4954f17ddefc51 Dmitry Safonov 2023-10-23  1555  	tcp_sigpool_end(&hp);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1556  err_free_pool:
4954f17ddefc51 Dmitry Safonov 2023-10-23  1557  	tcp_sigpool_release(pool_id);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1558  	return ERR_PTR(err);
4954f17ddefc51 Dmitry Safonov 2023-10-23  1559  }
4954f17ddefc51 Dmitry Safonov 2023-10-23  1560  

:::::: The code at line 1536 was first introduced by commit
:::::: 4954f17ddefc51d218625dcdfaf422a253dad3fa net/tcp: Introduce TCP_AO setsockopt()s

:::::: TO: Dmitry Safonov <dima@xxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux