Hi Jacopo, Laurent and all, Gentle ping. Are we happy with this patch series? Please let me know. Cheers, Biju > -----Original Message----- > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Sent: Monday, October 2, 2023 1:28 PM > Subject: [PATCH v11 0/4] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support > > This path series aims to add support for RZ/G2L DU DRM driver. > > RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), > Video signal processor (VSPD) and Display unit(DU). The output of LCDC is > connected to Display parallel interface and MIPI link video interface. > > The output from DSI is connected to ADV7535. > > Ref: > > This patch series is tested with [2] > [2] > > v10->v11: > * Replaced CONFIG_DRM_RCAR_VSP->CONFIG_VIDEO_RENESAS_VSP1 for building > rzg2l_du_vsp driver. > * Dropped "rzg2l_du_regs.h" instead the relevant definitions defined in > .c file. > * Dropped setting ditr5 based on latest HW manual 1.3.0/1.4.0 > * Updated the comment for auto clear. > * Replaced writel()->rzg2l_du_write() in rzg2l_du_start_stop(). > * Dropped CRC related functions as it does not have DISCOM. > * Replaced the variable possible_crtcs->possible_outputs in > struct rzg2l_du_output_routing. > * Updated DMA_BIT_MASK from 40->32. > * Dropped unneeded struct drm_bridge from rzg2l_du_drv.h. > * Dropped colour keying support as it doesn't have planes. > * Added only RGB formats in rzg2l_du_format_infos. > * Dropped chroma planes from rzg2l_du_fb_create(). > * Updated the comment for max_pitch in rzg2l_du_fb_create(). > * Dropped possible_crtcs check in rzg2l_du_encoders_init(). > * Dropped additional empty line from struct rzg2l_du_device. > v9->v10: > * patch#1 is mainlined, so dropped from this series. > * Added Rb tag from Laurent for the binding patch. > * Updated the commit description. > * Updated description of the port by dropping the text "specified in > Documentation/devicetree/bindings/graph.txt." > * Dropped empty endpoint from example. > * Dropped ARM64 dependency from Kconfig. > * Sorted the configs alphabetically in Kconfig. > * Dropped DRM_RCAR_VSP config option and make DRM_RZG2L_DU depend on > VIDEO_RENESAS_VSP1. > * On rzg2l_du_crtc_set_display_timing() replaced the setting of parent > clk rate with dclk rate. > * Added rzg2l_du_write() wrapper function. > * Updated the comment atomic_begin->atomic_flush. > * Dropped .atomic_check and .atomic_begin callback > * Renamed __rzg2l_du_crtc_plane_atomic_check->__rzg2l_du_vsp_plane_atomic > _check and moved it to rzg2l_du_vsp.c > * Added struct clk in rzg2l_du_crtc.h > * Dropped the variables mmio_offset,index,vblank_lock,vblank_wait, > vblank_count from struct rzg2l_du_crtc. > * Replaced the macro to_rzg2l_crtc with static inline functions. > * Dropped the unneeded header files clk.h, io.h, mm.h, pm.h, slab.h, > wait.h and drm_managed.h from rzg2l_du_drv.c. > * Replaced DRM_INFO->drm_info > * Dropped the callbacks prime_handle_to_fd, prime_fd_to_handle and > gem_prime_mmap. > * Replaced the callback remove->remove_new. > * Dropped header file wait.h and added forward declarations struct clk > and > rzg2l_du_device from rzg2l_du_drv.h. > * Dropped the dsi and dpad0_source variables from struct rzg2l_du_device. > * Replaced the macro to_rzg2l_encoder with static inline functions. > * Dropped header files dma-buf.h and wait.h from rzg2l_du_kms.c. > * Dropped struct sg_table and added the scatterlist.h header file in > rzg2l_du_vsp.h > * Added container_of.h header file, forward declarations struct device > and > struct rzg2l_du_device in rzg2l_du_vsp.h. > v8->v9: > * Added Rb tag from Laurent and Acked-by tag from Kieran for patch#1. > * Added Rb tag from Laurent and Geert for patch#3. > * Dropped reset_control_assert() from error patch for rzg2l_du_crtc_get() > as > suggested by Philipp Zabel. > * Added Rb tag from Laurent oatch#5. > * Updated MAINTAINERS entries for common parts(Makefile and Kconfig). > v7->v8: > * Moved rcar-du and shmobile DRM drivers to renesas specific vendor > directory. > * Fixed the typo vsp2->du in RZ/V2L DU bindings patch. > * Added Rb tag from Rob for RZ/V2L DU bindings patch. > * Dropped RCar du lib and created RZ/G2L DU DRM driver by creating rz_du > folder. > * Updated MAINTAINERS entries. > v6->v7: > * Split DU lib and RZ/G2L du driver as separate patch series as > DU support added to more platforms based on RZ/G2L alike SoCs. > * Rebased to latest drm-tip. > * Added patch #2 for binding support for RZ/V2L DU > * Added patch #4 for driver support for RZ/V2L DU > * Added patch #5 for SoC DTSI support for RZ/G2L DU > * Added patch #6 for SoC DTSI support for RZ/V2L DU > * Added patch #7 for Enabling DU on SMARC EVK based on RZ/{G2L,V2L} SoCs. > * Added patch #8 for Enabling DU on SMARC EVK based on RZ/G2LC SoC. > v5->v6: > * Merged DU lib and RZ/G2L du driver in same patch series > * Rebased to latest drm-misc. > * Merged patch#1 to RZ/G2L Driver patch. > * Updated KConfig dependency from ARCH_RENESAS->ARCH_RZG2L. > * Optimized rzg2l_du_output_name() by removing unsupported outputs. > > v4->v5: > * Added Rb tag from Rob for binding patch. > * Started using RCar DU libs(kms, vsp and encoder) > * Started using rcar_du_device, rcar_du_write, rcar_du_crtc, > rcar_du_format_info and rcar_du_encoder. > v3->v4: > * Changed compatible name from renesas,du-r9a07g044->renesas,r9a07g044-du > * started using same compatible for RZ/G2{L,LC} > * Removed rzg2l_du_group.h and struct rzg2l_du_group > * Renamed __rzg2l_du_group_start_stop->rzg2l_du_start_stop > * Removed rzg2l_du_group_restart > * Updated rzg2l_du_crtc_set_display_timing > * Removed mode_valid callback. > * Updated rzg2l_du_crtc_create() parameters > * Updated compatible > * Removed RZG2L_DU_MAX_GROUPS > V2->v3: > * Added new bindings for RZ/G2L DU > * Removed indirection and created new DRM driver based on R-Car DU > v1->v2: > * Based on [1], all references to 'rzg2l_lcdc' replaced with 'rzg2l_du' > * Updated commit description for bindings > * Removed LCDC references from bindings > * Changed clock name from du.0->aclk from bindings > * Changed reset name from du.0->du from bindings > * Replaced crtc_helper_funcs->rcar_crtc_helper_funcs > * Updated macro DRM_RZG2L_LCDC->DRM_RZG2L_DU > * Replaced rzg2l-lcdc-drm->rzg2l-du-drm > * Added forward declaration for struct reset_control > > [1] > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor > k.kernel.org%2Fproject%2Flinux-renesas-soc%2Fpatch%2F20220312084205.31462- > 2- > biju.das.jz%40bp.renesas.com%2F&data=05%7C01%7Cbiju.das.jz%40bp.renesas.co > m%7Ce669be40ca4449ebb44708dbc342fc7a%7C53d82571da1947e49cb4625a166a4a2a%7C > 0%7C0%7C638318464751238898%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ > QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jlkoTMl1 > V3JfKQchd3o0HhWvgppWE3q%2FBjejCWLcxX8%3D&reserved=0 > > Biju Das (4): > dt-bindings: display: Document Renesas RZ/G2L DU bindings > dt-bindings: display: renesas,rzg2l-du: Document RZ/V2L DU bindings > drm: renesas: Add RZ/G2L DU Support > MAINTAINERS: Add maintainer for RZ DU drivers > > .../bindings/display/renesas,rzg2l-du.yaml | 126 +++++ > MAINTAINERS | 15 +- > drivers/gpu/drm/renesas/Kconfig | 1 + > drivers/gpu/drm/renesas/Makefile | 1 + > drivers/gpu/drm/renesas/rz-du/Kconfig | 12 + > drivers/gpu/drm/renesas/rz-du/Makefile | 8 + > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 438 ++++++++++++++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.h | 89 ++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 176 +++++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.h | 78 > +++ .../gpu/drm/renesas/rz-du/rzg2l_du_encoder.c | 72 > +++ .../gpu/drm/renesas/rz-du/rzg2l_du_encoder.h | 32 ++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 441 ++++++++++++++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h | 43 ++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c | 469 ++++++++++++++++++ > drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.h | 97 ++++ > 16 files changed, 2096 insertions(+), 2 deletions(-) create mode 100644 > Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > create mode 100644 drivers/gpu/drm/renesas/rz-du/Kconfig > create mode 100644 drivers/gpu/drm/renesas/rz-du/Makefile > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.h > > -- > 2.25.1