On Mon, Oct 16, 2023 at 7:48 AM Christoph Hellwig <hch@xxxxxx> wrote: > Coldfire cores configured without a data cache are DMA coherent and > should thus simply use the simple coherent version of dma-direct. > > Introduce a new COLDFIRE_COHERENT_DMA Kconfig symbol as a convenient > short hand for such configurations, and a M68K_NONCOHERENT_DMA symbol > for all cases where we need to build non-coherent DMA infrastructure > to simplify the Kconfig and code conditionals. > > Not building the non-coherent DMA code slightly reduces the code > size for such configurations. > > Numers for m5249evb_defconfig below: > > text data bss dec hex filename > 2896158 401052 65392 3362602 334f2a vmlinux.before > 2895166 400988 65392 3361546 334b0a vmlinux.after > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> The m68kclassic-with-MMU parts look fine to me, so Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> I'll defer to Greg for the nommu and Coldfire parts... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds