Re: [PATCH net-next 3/8] dt-bindings: net: dsa/switch: Make 'ethernet-port' node addresses hex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17.10.2023 00:44, Rob Herring wrote:
'ethernet-port' node unit-addresses should be in hexadecimal. Some
instances have it correct, but fix the ones that don't.

Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
---
  Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml         | 2 +-
  Documentation/devicetree/bindings/net/dsa/dsa.yaml               | 2 +-
  Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml   | 6 +++---
  Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml | 2 +-
  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml       | 2 +-
  Documentation/devicetree/bindings/net/ethernet-switch.yaml       | 4 ++--
  Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml        | 2 +-
  7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
index aa3162c74833..75d8138298fb 100644
--- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
@@ -53,7 +53,7 @@ properties:
          const: 0
patternProperties:
-      "^port@[0-9]+$":
+      "^port@[0-9a-f]+$":
          type: object
$ref: ethernet-controller.yaml#
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index ec74a660beda..e6010821f86f 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -50,7 +50,7 @@ $defs:
              const: 0
patternProperties:
-          "^(ethernet-)?port@[0-9]+$":
+          "^(ethernet-)?port@[0-9a-f]+$":
              description: Ethernet switch ports
              $ref: dsa-port.yaml#
              unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index 20f7ba4e2203..5038818e9f2e 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -157,7 +157,7 @@ patternProperties:
      additionalProperties: true
patternProperties:
-      "^(ethernet-)?port@[0-9]+$":
+      "^(ethernet-)?port@[0-6]$":

You also restrict the pattern depending on how many ports the switch has.
Shouldn't this be a separate patch or, at the least, mentioned on the patch
log?

Regardless:

Acked-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

Arınç



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux