Hi Geert
> > Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx>
> > Signed-off-by: Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx>
> > Signed-off-by: Tam Nguyen <tam.nguyen.xa@xxxxxxxxxxx>
> > Signed-off-by: Hai Pham <hai.pham.ud@xxxxxxxxxxx>
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> Just as with "[PATCH v2 2/4]", please consider the transfer chain,
> and add Co-developed-by when needed.
It is based on BSP, but not as-is.
It is following same style of your similar patch (Based on BSP).
Co-developed with Shimoda-san. Will add it.
> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
>
> "OR", as per commit 05c618f39089d977 ("arm64: dts: use capital "OR"
> for multiple licenses in SPDX") in v6.6-rc2.
will fix in v3
> > + model = "R-Car S4 Starter Kit board";
>
> Renesas R-Car ...
Offical S4 SK doesn't have "Renesas".
> > +&i2c5 {
> > + pinctrl-0 = <&i2c5_pins>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > + clock-frequency = <400000>;
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c16";
>
> As the schematics say this is a genuine ST part:
>
> "st,24c16", "atmel,24c16";
I have removed "st,24c16", but will add again in v3
> > +&mmc0 {
> > + pinctrl-0 = <&sd_pins>;
> > + pinctrl-1 = <&sd_pins>;
> > + pinctrl-names = "default", "state_uhs";
>
> Do you need two states if there is a single voltage?
> AFAIK, UHS needs 1.8V.
>
> > +
> > + vmmc-supply = <&vcc_sdhi>;
> > + vqmmc-supply = <&vcc_sdhi>;
>
> Do you need vqmmc-supply if there is a single voltage?
> I'm not sure about this one...
Shimoda-san has double-checked.
It can use UHS, but this FPGA can't handle 1.8v.
v3 will remove UHS / vqmmc.
> > +&pfc {
(snip)
> Please sort alphabetically (everywhere).
will do
> This label seems to be copied from Spider?
> On S4SK, the PHY is IC99, so perhaps "ic99"?
> Although I'm open for a different name like "gbe_phy0"
> or "sgmii_phy0"?
(snip)
> Missing interrupt (GP3_10).
will fix in v3
Thank you for your help !!
Best regards
---
Kuninori Morimoto
