Hi Morimoto-san, On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit > board. Thanks for your patch! > Signed-off-by: Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> If this patch was developed by Goda-san, and you took it, and submitted it, there should be a "From: Yusuke Goda ..." line at the top. On the other hand, if you co-developed the patch with Goda-san, you can keep your From: line, being the first author, and there should be Co-developed-by tags, too: https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L489 > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > @@ -327,6 +327,7 @@ properties: > items: > - enum: > - renesas,spider-cpu # Spider CPU board (RTP8A779F0ASKB0SC2S) > + - renesas,s4sk # R-Car S4 Starter Kit board (Y-ASK-RCAR-S4-1000BASE-T#WS12) > - const: renesas,r8a779f0 The above would be fine if the S4SK board would have had an R8A779F0 SoC. Instead, it has an R8A779F4 SoC. So please add a section for R8A779F4, and document the new "renesas,s4sk" and "renesas,r8a779f4" compatible values, and the fallback to "renesas,r8a779f0". You can have a look at the R-Car V3H2 section for an example. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
