Hello Sergey,
> From: Sergey Shtylyov, Sent: Tuesday, September 26, 2023 6:13 PM
>
> Hello!
>
> You missed a colon after rswitch.
Oops! I'll fix this on v3.
> And historically we used simpler prefixes, like just sh_eth or ravb...
I see. So, I'll fix the subject as "rswitch: Fix PHY station management clock setting".
Best regards,
Yoshihiro Shimoda
> On 9/26/23 11:11 AM, Yoshihiro Shimoda wrote:
>
> > Fix the MPIC.PSMCS value following the programming example in the
> > section 6.4.2 Management Data Clock (MDC) Setting, Ethernet MAC IP,
> > S4 Hardware User Manual Rev.1.00.
> >
> > The value is calculated by
> > MPIC.PSMCS = clk[MHz] / (MDC frequency[MHz] * 2) - 1
> > with the input clock frequency from clk_get_rate() and MDC frequency
> > of 2.5MHz. Otherwise, this driver cannot communicate PHYs on the R-Car
> > S4 Starter Kit board.
> >
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Reported-by: Tam Nguyen <tam.nguyen.xa@xxxxxxxxxxx>
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> [...]
>
> MBR, Sergey
