Hi Morimoto-san,
On Wed, Sep 20, 2023 at 2:00 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
> +-- ULCB -------------------+
> |+--------+ +--------+|
> || SSI0| <---> |ak4613 ||
> || SSI1| <---> | ||
> || | +--------+|
> || | +--------+|
> || SSI2| <---> |HDMI ||
> || | +--------+|
> || SSI3| <--+ |
> || SSI4| <-+| |
> |+--------+ || |
> +-------------||------------+
> +-- Kingfisher -------------+
> | || +--------+|
> | |+->|pcm3168a||
> | +-->| ||
> | +--------+|
> +---------------------------+
>
> On UCLB/KF, we intuitively think we want to handle these
> as "2 Sound Cards".
>
> card0,0: 1st sound of ULCB (SSI0 - ak4613)
> card0,1: 2nd sound of ULCB (SSI2 - HDMI)
> card1,0: 1st sound of KF (SSI3 - pcm3168a)
> ^ ^
>
> But, we needed to handle it as "1 big Sound Card",
> because of ASoC Component vs Card framwork limitation.
>
> card0,0: 1st sound of ULCB/KF (SSI0 - ak4613)
> card0,1: 2nd sound of ULCB/KF (SSI2 - HDMI)
> card0,2: 3rd sound of ULCB/KF (SSI3 - pcm3168a)
> ^ ^
>
> Now ASoC support multi Component which allow us to handle "2 Sound Cards"
> such as "ULCB Sound Card" and "Kingfisher Sound Card".
>
> This patch updates all ULCB/KF Audio dtsi.
> One note is that Sound Card specification method from userland will be
> changed, especially for Kingfisher Sound.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> v1 -> v2
>
> - "ulcb" uses "port@0"
> - "ulcb" has #address-cells / #size-cells
Thanks for the update!
It looks much better now (I hope it still works?)
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf-audio-graph-card2-mix+split.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf-audio-graph-card2-mix+split.dtsi
> + ports@1 {
> + reg = <1>;
> + /*
> + * BE
> + *
> + * (Y) PCM3168A-p
> + */
checkpath: WARNING: Block comments should align the * on each line
> + be_y: port { be_y_ep: endpoint { remote-endpoint = <&pcm3168a_y_ep>; }; };
> + };
> };
> };
> };
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf-simple-audio-card-mix+split.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf-simple-audio-card-mix+split.dtsi
> @@ -115,7 +118,11 @@ &pcm3168a {
> };
>
> &rcar_sound {
> - rcar_sound,dai {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rcar_sound,dai@1 {
> + reg = <1>;
Can you please make a similar change for "rcar_sound,dai", i.e. use
"rcar_sound,dai@0" and add #{address,size}-cells in the ULCB DTS files?
>
> /* dai0-1 are defined in ulcb.dtsi */
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
