Re: [PATCH] clk: renesas: r8a7795: Constify r8a7795_*_clks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

Thanks for your patch!

On Sun, Sep 17, 2023 at 11:58 AM Marek Vasut
<marek.vasut+renesas@xxxxxxxxxxx> wrote:
> Make r8a7795_core_clks and r8a7795_mod_clks arrays const and align them
> with the other clock tables in other *cpg-mssr.c . No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

Indeed, these are no longer modified since commit b1dec4e78599a2ce
("clk: renesas: rcar-gen3: Disable R-Car H3 ES1.*").

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-clk-for-v6.7.

> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -51,7 +51,7 @@ enum clk_ids {
>         MOD_CLK_BASE
>  };
>
> -static struct cpg_core_clk r8a7795_core_clks[] __initdata = {
> +static const struct cpg_core_clk r8a7795_core_clks[] __initconst = {
>         /* External Clock Inputs */
>         DEF_INPUT("extal",      CLK_EXTAL),
>         DEF_INPUT("extalr",     CLK_EXTALR),
> @@ -128,7 +128,7 @@ static struct cpg_core_clk r8a7795_core_clks[] __initdata = {
>         DEF_BASE("r",           R8A7795_CLK_R,     CLK_TYPE_GEN3_R, CLK_RINT),
>  };
>
> -static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
> +static const struct mssr_mod_clk r8a7795_mod_clks[] __initconst = {
>         DEF_MOD("3dge",                  112,   R8A7795_CLK_ZG),
>         DEF_MOD("fdp1-1",                118,   R8A7795_CLK_S0D1),
>         DEF_MOD("fdp1-0",                119,   R8A7795_CLK_S0D1),

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux