On 30/08/2023 17:18, Biju Das wrote: >>> regmap_update_bits(rpc->regmap, RPCIF_CMNCR, @@ -774,6 >>> +776,12 @@ static int rpcif_probe(struct platform_device *pdev) >>> return ret; >>> } >>> >>> + if (rpc->info->type == RPCIF_RZ_G2L && >> >> Wouldn't this apply to non-RZ/G2L systems, too? > > It applies, if the device uses the flash[1] or [2] and it needs > 4-bit tx support. > > [1] Figure 20: QUAD INPUT/OUTPUT FAST READ – EBh/ECh > https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-a/mt25q_qlks_u_512_aba_0.pdf?rev=3e5b2a574f7b4790b6e58dacf4c889b2 > > [2] section 8.14 > > https://www.renesas.com/eu/en/document/dst/at25ql128a-datasheet?r=1608586 > Geert, Does it answer your comment or do you expect here some changes? Best regards, Krzysztof
