Hi Shimoda-san,
On Mon, Aug 28, 2023 at 6:14 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> Enable PCIe Host controller channel 0 on R-Car S4-8 Spider board.
>
> Since this board has an Oculink connector, CLKREQ# pin of PFC for PCIe
> should not be used. So, using a GPIO is used to output the clock instead.
> Otherwise the controller cannot detect a PCIe device.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> @@ -145,6 +157,11 @@ &mmc0 {
> status = "okay";
> };
>
> +&pciec0 {
> + reset-gpio = <&gpio_exp_20 0 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +};
> +
> &pfc {
> pinctrl-0 = <&scif_clk_pins>;
> pinctrl-names = "default";
> @@ -202,6 +219,13 @@ &ufs {
> status = "okay";
> };
>
> +&pcie0_clkref {
Please move this node up to preserve alphabetical sort order.
> + compatible = "gpio-gate-clock";
> + clocks = <&rc21012_pci>;
> + enable-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
> + /delete-property/ clock-frequency;
> +};
> +
> &ufs30_clk {
> compatible = "gpio-gate-clock";
> clocks = <&rc21012_ufs>;
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
