On Tue, 8 Aug 2023 16:05:48 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Mon, Aug 07, 2023 at 06:25:48PM +0100, Biju Das wrote: > > Simplify the probe() by replacing device_get_match_data() and > > i2c_client_get_device_id by i2c_get_match_data() as we have similar I2C, > > ACPI and DT matching table. > > ... > > > - name = dev_name(&client->dev); > > > - name = id->name; > > > - indio_dev->name = name; > > + indio_dev->name = dev_name(&client->dev); > > I believe this is an ABI breakage. Using dev_name(&client->dev) was an old bug but we missed it in a few drivers for long enough that we didn't want to risk breaking userspace by fixing it :( With hindsight we should have added more comments to the code though so people would know to beware. Jonathan > > NAK. >
