Hi Andy Shevchenko,
Thanks for the feedback.
> Subject: Re: [PATCH] regulator: sy8824x: Make similar OF and ID table
>
> On Sat, Aug 26, 2023 at 06:11:58PM +0100, Biju Das wrote:
> > Make similar OF and ID table to extend support for ID match using
> > i2c_match_data(). Currently it works only for OF match tables as the
> > driver_data is wrong for ID match.
>
> ...
>
> > { }
> > };
> > MODULE_DEVICE_TABLE(of, sy8824_dt_ids);
>
> ...
>
> > static const struct i2c_device_id sy8824_id[] = {
> > - { "sy8824", },
> > + { "sy8824", (kernel_ulong_t)&sy8824c_cfg },
>
> > { },
>
> Here is even inconsistency with usage of trailing comma in the terminator
> entry.
OK, it is carry over from original code. Will fix it in v2.
Cheers,
Biju
