Hi Andy Shevchenko, Thanks for the feedback. > Subject: Re: [PATCH] mfd: arizona-i2c: Simplify probe() > > On Sat, Aug 26, 2023 at 10:27:21AM +0100, Biju Das wrote: > > Simplify probe() by replacing device_get_match_data() and ID lookup > > for retrieving match data by i2c_get_match_data(). > > ... > > > - match_data = device_get_match_data(&i2c->dev); > > - if (match_data) > > - type = (unsigned long)match_data; > > - else if (id) > > - type = id->driver_data; > > + type = (unsigned long)i2c_get_match_data(i2c); > > > > > You now can drop this blank line. Agreed. Cheers, Biju > > > switch (type) { > > -- > With Best Regards, > Andy Shevchenko >