On Sat, Aug 26, 2023 at 09:22:17AM +0100, Biju Das wrote: > Make similar OF and ID table to extend support for ID match using > i2c_match_data(). Currently it works only for OF match tables as the > driver_data is wrong for ID match. ... > -static const struct i2c_device_id palmas_i2c_id[] = { > - { "palmas", }, > - { "twl6035", }, > - { "twl6037", }, > - { "tps65913", }, > - { /* end */ } > -}; > -MODULE_DEVICE_TABLE(i2c, palmas_i2c_id); Why do you move it up? The first user of the table is below this code. -- With Best Regards, Andy Shevchenko