Hi Geert Uytterhoeven, Thanks for the feedback. > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: versaclock3: Fix the > assigned-clock-rates > > Hi Biju, > > On Thu, Aug 24, 2023 at 10:25 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Fix the "assigned-clock-rates" for each clock output in the example > > based on Table 3. ("Output Source") in the 5P35023 > > datasheet(ie: {REF,SE1,SE2,SE3,DIFF1,DIFF2}). > > > > While at it, replace clocks phandle in the example from x1_x2->x1 as > > X2 is a different 32768 kHz crystal. > > Thanks for your patch! > > > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > This is not what I suggested. > The bindings should document the meaning of the clock indices. OK, will add this meaning in description. > > > Fixes: a03d23f860eb ("dt-bindings: clock: Add Renesas versa3 clock > > generator bindings") > > This patch is not a critical fix. Will remove it in next version. Cheers, Biju