Re: [PATCH -next 19/24] spi: sh-hspi: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master to modern name host.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-sh-hspi.c
> +++ b/drivers/spi/spi-sh-hspi.c

> @@ -137,7 +137,7 @@ static void hspi_hw_setup(struct hspi_priv *hspi,
>
>         hspi_write(hspi, SPCR, spcr);
>         hspi_write(hspi, SPSR, 0x0);
> -       hspi_write(hspi, SPSCR, 0x21);  /* master mode / CS control */
> +       hspi_write(hspi, SPSCR, 0x21);  /* host mode / CS control */

Please do not change this comment, as it matches the register bit
documentation in Rev. 1.00 of the  R-Car H1 Hardware User's Manual.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds