On Sat, Aug 12, 2023 at 10:04:18AM +0100, Biju Das wrote: > Replace device_get_match_data() and id lookup for retrieving match data > by i2c_get_match_data() by converting enum->pointer for data in the > match table. ... > + {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] }, > + {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] }, > + {.compatible = "ti,dac7571", .data = &dac5571_spec[single_12bit] }, > + {.compatible = "ti,dac5574", .data = &dac5571_spec[quad_8bit] }, > + {.compatible = "ti,dac6574", .data = &dac5571_spec[quad_10bit] }, > + {.compatible = "ti,dac7574", .data = &dac5571_spec[quad_12bit] }, > + {.compatible = "ti,dac5573", .data = &dac5571_spec[quad_8bit] }, > + {.compatible = "ti,dac6573", .data = &dac5571_spec[quad_10bit] }, > + {.compatible = "ti,dac7573", .data = &dac5571_spec[quad_12bit] }, > + {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] }, I would reorder them a bit. {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] }, {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] }, {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] }, {.compatible = "ti,dac7571", .data = &dac5571_spec[single_12bit] }, {.compatible = "ti,dac5573", .data = &dac5571_spec[quad_8bit] }, {.compatible = "ti,dac6573", .data = &dac5571_spec[quad_10bit] }, {.compatible = "ti,dac7573", .data = &dac5571_spec[quad_12bit] }, {.compatible = "ti,dac5574", .data = &dac5571_spec[quad_8bit] }, {.compatible = "ti,dac6574", .data = &dac5571_spec[quad_10bit] }, {.compatible = "ti,dac7574", .data = &dac5571_spec[quad_12bit] }, Same for I2C ID table. -- With Best Regards, Andy Shevchenko