On Thu, 3 Aug 2023 21:06:20 +0900 Yoshihiro Shimoda wrote: > +static const struct soc_device_attribute rswitch_soc_match[] = { nit: maybe a better than for this table would be good? To indicate what IDs it holds. E.g. rswitch_soc_no_speed_change[] ? > + { .soc_id = "r8a779f0", .revision = "ES1.0" }, > + { /* Sentinel */ } > +}; -- pw-bot: cr