Hi Dmitry Torokhov, Thanks for the feedback. > Subject: Re: [PATCH v4 3/3] i2c: Extend i2c_device_get_match_data() to > support i2c sysfs > > Hi Niju, > > On Wed, Aug 02, 2023 at 12:23:17PM +0100, Biju Das wrote: > > @@ -141,6 +141,7 @@ i2c_of_match_device_sysfs(const struct > of_device_id *matches, > > > > return NULL; > > } > > +EXPORT_SYMBOL_GPL(i2c_of_match_device_sysfs); > > This is private to i2c core, you do not need to export it to modules. Agreed. Drop this export in next version. Cheers, Biju