Re: [PATCH v2 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix overflow/underflow interrupt names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Tue, Jul 25, 2023 at 11:11 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > On Mon, Jul 24, 2023 at 11:19 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> > > interrupt names starts with 'tci' instead of 'tgi'.
> > >
> > > Fix this documentation issue by replacing below overflow/underflow
> > > interrupt names:
> > >  - tgiv0->tciv0
> > >  - tgiv1->tciv1
> > >  - tgiu1->tciu1
> > >  - tgiv2->tciv2
> > >  - tgiu2->tciu2
> > >  - tgiv3->tciv3
> > >  - tgiv4->tciv4
> > >  - tgiv6->tciv6
> > >  - tgiv7->tciv7
> > >  - tgiv8->tciv8
> > >  - tgiu8->tciu8
> > >
> > > Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a
> > > bindings")
> > > Cc: stable@xxxxxxxxxx
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > > ---
> > > v1->v2:
> > >  * Added Ack from Conor Dooley.
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> > > +++ b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> >
> > > @@ -197,18 +197,18 @@ properties:
> > >        - const: tgib6
> > >        - const: tgic6
> > >        - const: tgid6
> > > -      - const: tgiv6
> > > +      - const: tciv6
> > >        - const: tgia7
> > >        - const: tgib7
> > >        - const: tgic7
> > >        - const: tgid7
> > > -      - const: tgiv7
> > > +      - const: tciv7
> > >        - const: tgia8
> > >        - const: tgib8
> > >        - const: tgic8
> > >        - const: tgid8
> > > -      - const: tgiv8
> > > -      - const: tgiu8
> > > +      - const: tciv8
> > > +      - const: tciu8
> >
> > According to the documentation, there is no underflow interrupt for
> > channel 8?
>
> I got confirmation from HW manual team.
>
> Table 8.2 in the HW manual is correct. ie, underflow interrupt is present
> for channel 8.

Thanks for checking!

> They are going to correct Table16.78 in Chapter 16 MTU3a.

+ Table 16.2 and Figure 16.1.

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux