Re: [PATCH v2 4/6] arm64: dts: renesas: r9a07g044: Update overfow/underflow IRQ names for MTU3 channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Mon, Jul 24, 2023 at 11:19 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> interrupt names starts with 'tci' instead of 'tgi'.
>
> Replace the below overflow/underflow interrupt names:
>  - tgiv0->tciv0
>  - tgiv1->tciv1
>  - tgiu1->tciu1
>  - tgiv2->tciv2
>  - tgiu2->tciu2
>  - tgiv3->tciv3
>  - tgiv4->tciv4
>  - tgiv6->tciv6
>  - tgiv7->tciv7
>  - tgiv8->tciv8
>  - tgiu8->tciu8
>
> Fixes: 26336d66d021 ("arm64: dts: renesas: r9a07g044: Add MTU3a node")
> Fixes: dd123dd01def ("arm64: dts: renesas: r9a07g054: Add MTU3a node")

These were added in v6.5-rc1, so it would be good to get this fixed before
the final release of v6.5 (i.e. before I sent my first PR for v6.6
later this week).

> Cc: stable@xxxxxxxxxx

No need to CC stable.

> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v1->v2:
>  * No change.

Thanks for your patch!
> ---
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 16 ++++++++--------
>  arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 16 ++++++++--------
>  2 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> index 232910e07444..66f68fc2b241 100644
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -223,20 +223,20 @@ mtu3: timer@10001200 {
>                                      <GIC_SPI 212 IRQ_TYPE_EDGE_RISING>,
>                                      <GIC_SPI 213 IRQ_TYPE_EDGE_RISING>;
>                         interrupt-names = "tgia0", "tgib0", "tgic0", "tgid0",
> -                                         "tgiv0", "tgie0", "tgif0",
> -                                         "tgia1", "tgib1", "tgiv1", "tgiu1",
> -                                         "tgia2", "tgib2", "tgiv2", "tgiu2",
> +                                         "tciv0", "tgie0", "tgif0",
> +                                         "tgia1", "tgib1", "tciv1", "tciu1",
> +                                         "tgia2", "tgib2", "tciv2", "tciu2",
>                                           "tgia3", "tgib3", "tgic3", "tgid3",
> -                                         "tgiv3",
> +                                         "tciv3",
>                                           "tgia4", "tgib4", "tgic4", "tgid4",
> -                                         "tgiv4",
> +                                         "tciv4",
>                                           "tgiu5", "tgiv5", "tgiw5",
>                                           "tgia6", "tgib6", "tgic6", "tgid6",
> -                                         "tgiv6",
> +                                         "tciv6",
>                                           "tgia7", "tgib7", "tgic7", "tgid7",
> -                                         "tgiv7",
> +                                         "tciv7",
>                                           "tgia8", "tgib8", "tgic8", "tgid8",
> -                                         "tgiv8", "tgiu8";
> +                                         "tciv8", "tciu8";
>                         clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
>                         power-domains = <&cpg>;
>                         resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;

While SPI 213 is documented to be used for TCIU8, the actual MTU3a
documentation does not mention this interrupt.

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux