RE: [PATCH] net: Explicitly include correct DT includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2023年7月15日 1:48
> To: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>; Wolfgang
> Grandegger <wg@xxxxxxxxxxxxxx>; Marc Kleine-Budde
> <mkl@xxxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Chandrasekar Ramakrishnan
> <rcsekar@xxxxxxxxxxx>; Chen-Yu Tsai <wens@xxxxxxxx>; Jernej Skrabec
> <jernej.skrabec@xxxxxxxxx>; Samuel Holland <samuel@xxxxxxxxxxxx>; Florian
> Fainelli <florian.fainelli@xxxxxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>;
> Vladimir Oltean <olteanv@xxxxxxxxx>; Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>;
> Woojung Huh <woojung.huh@xxxxxxxxxxxxx>;
> UNGLinuxDriver@xxxxxxxxxxxxx; Arınç ÜNAL <arinc.unal@xxxxxxxxxx>;
> Daniel Golle <daniel@xxxxxxxxxxxxxx>; Landen Chao
> <Landen.Chao@xxxxxxxxxxxx>; DENG Qingfang <dqfext@xxxxxxxxx>; Sean
> Wang <sean.wang@xxxxxxxxxxxx>; Matthias Brugger
> <matthias.bgg@xxxxxxxxx>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx>; Claudiu Manoil
> <claudiu.manoil@xxxxxxx>; Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>;
> Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>; George McCollister
> <george.mccollister@xxxxxxxxx>; Andreas Larsson <andreas@xxxxxxxxxxx>;
> Iyappan Subramanian <iyappan@xxxxxxxxxxxxxxxxxxxxxx>; Keyur Chudgar
> <keyur@xxxxxxxxxxxxxxxxxxxxxx>; Chris Snook <chris.snook@xxxxxxxxx>;
> Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>; Claudiu Beznea
> <claudiu.beznea@xxxxxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> Wei Fang <wei.fang@xxxxxxx>; Shenwei Wang <shenwei.wang@xxxxxxx>;
> Clark Wang <xiaoning.wang@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> Sean Anderson <sean.anderson@xxxxxxxx>; Pantelis Antoniou
> <pantelis.antoniou@xxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Yisen Zhuang
> <yisen.zhuang@xxxxxxxxxx>; Salil Mehta <salil.mehta@xxxxxxxxxx>;
> Douglas Miller <dougmill@xxxxxxxxxxxxx>; Marcin Wojtas
> <mw@xxxxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Tara s Chornyi
> <taras.chornyi@xxxxxxxxxxx>; Mirko Lindner <mlindner@xxxxxxxxxxx>;
> Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>; Felix Fietkau
> <nbd@xxxxxxxx>; John Crispin <john@xxxxxxxxxxx>; Mark Lee
> <Mark-MC.Lee@xxxxxxxxxxxx>; Lorenzo Bianconi <lorenzo@xxxxxxxxxx>;
> Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>; Timur Tabi
> <timur@xxxxxxxxxx>; Sergey Shtylyov <s.shtylyov@xxxxxx>; Steve Glendinning
> <steve.glendinning@xxxxxxxxxxx>; Kunihiko Hayashi
> <hayashi.kunihiko@xxxxxxxxxxxxx>; Giuseppe Cavallaro
> <peppe.cavallaro@xxxxxx>; Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>;
> Jose Abreu <joabreu@xxxxxxxxxxxx>; Maxime Coquelin
> <mcoquelin.stm32@xxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha
> Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team
> <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; Neil
> Armstrong <neil.armstrong@xxxxxxxxxx>; Kevin Hilman
> <khilman@xxxxxxxxxxxx>; Jerome Brunet <jbrunet@xxxxxxxxxxxx>; Martin
> Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; Vinod Ko ul
> <vkoul@xxxxxxxxxx>; Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>; Emil
> Renner Berthing <kernel@xxxxxxxx>; Samin Guo
> <samin.guo@xxxxxxxxxxxxxxxx>; Thierry Reding <thierry.reding@xxxxxxxxx>;
> Jonathan Hunter <jonathanh@xxxxxxxxxx>; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>; Grygorii Strashko
> <grygorii.strashko@xxxxxx>; Kevin Brace
> <kevinbrace@xxxxxxxxxxxxxxxxxxxx>; Francois Romieu
> <romieu@xxxxxxxxxxxxx>; Michal Simek <michal.simek@xxxxxxx>; Radhey
> Shyam Pandey <radhey.shyam.pandey@xxxxxxx>; Alexander Aring
> <alex.aring@xxxxxxxxx>; Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>;
> Miquel Raynal <miquel.raynal@xxxxxxxxxxx>; Alex Elder <elder@xxxxxxxxxx>;
> Clément Léger <clement.leger@xxxxxxxxxxx>; Heiner Kallweit
> <hkallweit1@xxxxxxxxx>; SkyLake Huang <SkyLake.Huang@xxxxxxxxxxxx>;
> Kalle Valo <kvalo@xxxxxxxxxx>; Loic Poulain <loic.poulain@xxxxxxxxxx>; Ryder
> Lee <ryder.lee@xxxxxxxxxxxx>; Shayne Chen <shayne.chen@xxxxxxxxxxxx>;
> Jérôme Pouille r <jerome.pouiller@xxxxxxxxxx>; Richard Cochran
> <richardcochran@xxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-sunxi@xxxxxxxxxxxxxxx;
> linux-mediatek@xxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> linux-renesas-soc@xxxxxxxxxxxxxxx;
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux-oxnas@xxxxxxxxx;
> linux-tegra@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx;
> linux-wpan@xxxxxxxxxxxxxxx; ath10k@xxxxxxxxxxxxxxxxxxx;
> linux-wireless@xxxxxxxxxxxxxxx; ath11k@xxxxxxxxxxxxxxxxxxx;
> wcn36xx@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] net: Explicitly include correct DT includes
> 
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h and of.h.
> As a result, there's a pretty much random mix of those include files used
> throughout the tree. In order to detangle these headers and replace the
> implicit includes with struct declarations, users need to explicitly include the
> correct includes.
> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index ab86bb8562ef..9428a06b6a87 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -30,7 +30,6 @@
>  #include <linux/phy.h>
>  #include <linux/fec.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/of_net.h>
> 
Thanks!
Reviewed-by: Wei Fang <wei.fang@xxxxxxx>





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux