Hi Geert,
Thanks for clarification.
> Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a
>
> Hi Biju,
>
> On Mon, Jul 10, 2023 at 7:04 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Sent: Wednesday, July 5, 2023 12:44 PM
> > > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Cc: Lee Jones <lee@xxxxxxxxxx>; Prabhakar Mahadev Lad
> > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; linux-renesas-
> > > soc@xxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a
> > >
> > > On Mon, Jul 3, 2023 at 3:23 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > wrote:
> > > > Modified Kconfig to enable module build support for RZ/G2L MTU3a
> > > driver.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > >
> > > As drivers/mfd/rz-mtu3.c already has the needed MODULE_*() lines:
> > >
> > > drivers/mfd/rz-mtu3.c:MODULE_DEVICE_TABLE(of, rz_mtu3_of_match);
> > > drivers/mfd/rz-mtu3.c:MODULE_AUTHOR("Biju Das
> > > <biju.das.jz@xxxxxxxxxxxxxx>"); drivers/mfd/rz-
> > > mtu3.c:MODULE_DESCRIPTION("Renesas RZ/G2L MTU3a Core Driver");
> > > drivers/mfd/rz-mtu3.c:MODULE_LICENSE("GPL");
> >
> > You mean, I missed adding linux/module.h as I got compilation error
> > While backporting to 5.10 cip kernel?
>
> No, I didn't mean that. I just clarified that the MODULE_*() machinery
> was already there, so it's fine to make the driver modular.
> I hadn't noticed the include was forgotten. Doh...
OK, will send v2 with missing include file.
Cheers,
Biju
