On 7/5/23 19:48, Alistair Francis wrote: > pci-epc.h doesn't define the members of the pci_epf_header struct, so > trying to access them results in errors like this: > > error: invalid use of undefined type 'struct pci_epf_header' > 167 | val = hdr->vendorid; > > Instead let's include pci-epf.h which not only defines the > pci_epf_header but also includes pci-epc.h. > > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx> It is odd that the the build bot did not detect this... Looks good. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > --- > drivers/pci/controller/pcie-rcar-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c > index f9682df1da61..5afc91d11eef 100644 > --- a/drivers/pci/controller/pcie-rcar-ep.c > +++ b/drivers/pci/controller/pcie-rcar-ep.c > @@ -10,7 +10,7 @@ > #include <linux/of_address.h> > #include <linux/of_platform.h> > #include <linux/pci.h> > -#include <linux/pci-epc.h> > +#include <linux/pci-epf.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > -- Damien Le Moal Western Digital Research
