Mon, Jul 03, 2023 at 12:19:26PM +0200, Geert Uytterhoeven kirjoitti: > On Thu, Jun 22, 2023 at 1:34 PM Fabrizio Castro > <fabrizio.castro.jz@xxxxxxxxxxx> wrote: ... > > + if (csi->txbuf) > > + /* > > + * Leaving a little bit of headroom in the FIFOs makes it very > > + * hard to raise an overflow error (which is only possible > > + * when IP transmits and receives at the same time). > > + */ > > + to_transfer = min_t(int, CSI_FIFO_HALF_SIZE, bytes_remaining); > > + else > > + to_transfer = min_t(int, CSI_FIFO_SIZE_BYTES, bytes_remaining); > > Why min_t(int, ...)? Both values are int. min_t() should be used with a great care. > It would be better to make both unsigned, though. I believe you are assuming 3 (three) values and not 2 (two) under "both" (one variable and two definitions). -- With Best Regards, Andy Shevchenko
