Tue, Jul 04, 2023 at 12:18:58PM +0100, Biju Das kirjoitti:
> Currently, sd1 and sd0 have unique subnode names 'sd1_mux' and 'sd0_mux'.
> If we change it to a non-unique subnode name such as 'mux' this can lead
> to the below conflicts as the RZ/G2L pin control driver considers only the
> names of the subnodes.
>
> pinctrl-rzg2l 11030000.pinctrl: pin P47_0 already requested by 11c00000.mmc; cannot claim for 11c10000.mmc
> pinctrl-rzg2l 11030000.pinctrl: pin-376 (11c10000.mmc) status -22
> pinctrl-rzg2l 11030000.pinctrl: could not request pin 376 (P47_0) from group mux on device pinctrl-rzg2l
> renesas_sdhi_internal_dmac 11c10000.mmc: Error applying setting, reverse things back
>
> Fix this by constructing unique names from the node names of both the
> pin control configuration node and its child node, where appropriate.
>
> Based on the work done by Geert for RZ/V2M pinctrl driver.
...
> + if (parent) {
> + name = devm_kasprintf(pctrl->dev, GFP_KERNEL, "%pOFn.%pOFn",
> + parent, np);
Is devm_*() usage appropriate here?
> + if (!name) {
> + ret = -ENOMEM;
> + goto done;
> + }
> + } else {
> + name = np->name;
> + }
--
With Best Regards,
Andy Shevchenko
