The built-in RTC found on PMIC RAA215300 is the same as ISL1208.
However, the external oscillator bit is inverted on PMIC version
0x11. The PMIC driver detects PMIC version and instantiates the
RTC device based on i2c_device_id.
Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
v6->v7:
* Dropped Rb tag from Geert as there is new changes.
* Dropped parsing the parent node for retrieving clk details as
clk_dev is registered in sibling PMIC driver. So same info available
here.
v5->v6:
* Added Rb tag from Geert.
* Parsing of parent node is moved from probe->isl1208_clk_present()
* Added comment for parsing parent node for getting clock resource.
* Replaced XOR->NOT to make the operation more clear for the inverted case.
v4->v5:
* Updated commit description.
* Replaced "unsigned long"->"kernel_ulong_t" in isl1208_id[].
* -ENOENT means clock not present, so any other errors are propagated.
* Dropped bool inverted parameter from isl1208_set_xtoscb() instead
using xor to compute the value of xtoscb.
v3->v4:
* Added support for internal oscillator enable/disable.
v2->v3:
* RTC device is instantiated by PMIC driver and dropped isl1208_probe_helper().
* Added "TYPE_RAA215300_RTC_A0" to handle inverted oscillator bit case.
RFC->v2:
* Dropped compatible "renesas,raa215300-isl1208" and "renesas,raa215300-pmic" property.
* Updated the comment polarity->bit for External Oscillator.
* Added raa215300_rtc_probe_helper() for registering raa215300_rtc device and
added the helper function isl1208_probe_helper() to share the code.
---
drivers/rtc/rtc-isl1208.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index e9ec5675e27c..b0712b4e3648 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -74,6 +74,7 @@ struct isl1208_config {
unsigned int nvmem_length;
unsigned has_tamper:1;
unsigned has_timestamp:1;
+ unsigned has_inverted_osc_bit:1;
};
static const struct isl1208_config config_isl1208 = {
@@ -100,11 +101,19 @@ static const struct isl1208_config config_isl1219 = {
.has_timestamp = true
};
+static const struct isl1208_config config_raa215300_a0 = {
+ .nvmem_length = 2,
+ .has_tamper = false,
+ .has_timestamp = false,
+ .has_inverted_osc_bit = true
+};
+
static const struct i2c_device_id isl1208_id[] = {
{ "isl1208", .driver_data = (kernel_ulong_t)&config_isl1208 },
{ "isl1209", .driver_data = (kernel_ulong_t)&config_isl1209 },
{ "isl1218", .driver_data = (kernel_ulong_t)&config_isl1218 },
{ "isl1219", .driver_data = (kernel_ulong_t)&config_isl1219 },
+ { "raa215300_a0", .driver_data = (kernel_ulong_t)&config_raa215300_a0 },
{ }
};
MODULE_DEVICE_TABLE(i2c, isl1208_id);
@@ -895,6 +904,9 @@ isl1208_probe(struct i2c_client *client)
return sr;
}
+ if (isl1208->config->has_inverted_osc_bit)
+ xtosb_val = !xtosb_val;
+
rc = isl1208_set_xtoscb(client, sr, xtosb_val);
if (rc)
return rc;
--
2.25.1
