On Thu, Jun 15, 2023 at 03:37:49PM +0300, Laurent Pinchart wrote: > Hello, > > On Thu, Jun 15, 2023 at 06:22:45AM +0000, Biju Das wrote: > > Hi Dan Carpenter, > > > > Thanks for the feedback. > > > > + Laurent. > > > > It is already validated in [1] > > > > [1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c#L619 > > > > So we won't get wrong formats in rzg2l_mipi_dsi_set_display_timing(). > > > > Laurent, Please correct me if I am wrong. > > The issue is that static checkers can't know that. You should add a > default statement to the switch, possibly with a comment to explain why. > Yeah. Smatch is bad at tracking things which happen in separate system calls. I hope eventually to be able to silence this warning in Smatch but that's still some time away. I don't have strong feelings that we need to silence every static checker warning. Generally the rule of thumb is that we should always fix the checker instead. regards, dan carpenter
