RE: [PATCH v4] i2c: Add i2c_get_match_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram Sang,

> Subject: Re: [PATCH v4] i2c: Add i2c_get_match_data()
> 
> On Wed, Jun 07, 2023 at 05:57:38PM +0100, Biju Das wrote:
> > Add i2c_get_match_data() to get match data for I2C, ACPI and DT-based
> > matching, so that we can optimize the driver code.
> >
> > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> No further comments, yet I like it, so:
> 
> Applied to for-next, thanks!
> 
> With one minor change, I hope you are okay with it:
> 
> > +	struct device_driver *drv = client->dev.driver;
> > +	struct i2c_driver *driver = to_i2c_driver(drv);
> 
> Variables 'drv' and 'driver' sounds like it could cause confusion later.
> I merged the two and eliminated 'drv' that way.

Yes, it is much better.

Cheers,
Biju





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux