RE: [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon-san,

> From: Simon Horman, Sent: Thursday, June 8, 2023 12:26 AM
> 
> On Wed, Jun 07, 2023 at 04:01:41PM +0900, Yoshihiro Shimoda wrote:
> > The timestamp descriptors were intended to act cyclically. Descriptors
> > from index 0 through gq->ring_size - 1 contain actual information, and
> > the last index (gq->ring_size) should have LINKFIX to indicate
> > the first index 0 descriptor. However, thie LINKFIX value is missing,
> 
> Hi Shimoda-san,
> 
> a very minor nit, in case you end up posting a v3 for some other reason:
> 
> 	thie -> the

Thank you for your review! I'll fix this on v3.

Best regards,
Yoshihiro Shimoda

> > causing the timestamp feature to stop after all descriptors are used.
> > To resolve this issue, set the LINKFIX to the timestamp descritors.
> >
> > Reported-by: Phong Hoang <phong.hoang.wz@xxxxxxxxxxx>
> > Fixes: 33f5d733b589 ("net: renesas: rswitch: Improve TX timestamp accuracy")
> 
> ...




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux